[PATCH] D65055: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/SanitizerCommon.PthreadDestructorIterations on Solaris

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 11:55:44 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL367705: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*… (authored by ro, committed by ).
Herald added a subscriber: delcypher.

Changed prior to commit:
  https://reviews.llvm.org/D65055?vs=212994&id=213105#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65055/new/

https://reviews.llvm.org/D65055

Files:
  compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_posix_test.cpp


Index: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_posix_test.cpp
===================================================================
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_posix_test.cpp
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_posix_test.cpp
@@ -54,7 +54,12 @@
   SpawnThread(GetPthreadDestructorIterations());
   EXPECT_TRUE(destructor_executed);
   SpawnThread(GetPthreadDestructorIterations() + 1);
+#if SANITIZER_SOLARIS
+  // Solaris continues calling destructors beyond PTHREAD_DESTRUCTOR_ITERATIONS.
+  EXPECT_TRUE(destructor_executed);
+#else
   EXPECT_FALSE(destructor_executed);
+#endif
   ASSERT_EQ(0, pthread_key_delete(key));
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65055.213105.patch
Type: text/x-patch
Size: 695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190802/d30ee608/attachment.bin>


More information about the llvm-commits mailing list