[PATCH] D64908: Fix and test inter-procedural register allocation for ARM

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 02:45:48 PDT 2019


ostannard marked 2 inline comments as done and an inline comment as not done.
ostannard added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetRegisterInfo.h:496
+  virtual const MCPhysReg *
+  getIntraCallClobberedRegs(const MachineFunction *MF) const {
+    return nullptr;
----------------
dmgreen wrote:
> This returns a Null terminated list (or null), in the same way as getCalleeSavedRegs above? I guess that's Ok.
> 
> An arrayref might be a better interface for it, all the same.
Yes, it matches the functions above, but I suppose an ArrayRef would be a better interface, so I'll change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64908/new/

https://reviews.llvm.org/D64908





More information about the llvm-commits mailing list