[PATCH] D63972: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks

Zhang Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 00:57:46 PDT 2019


ZhangKang added a comment.

In D63972#1608824 <https://reviews.llvm.org/D63972#1608824>, @efriedma wrote:

> Okay, delaying some of the work to sense, since you can't really modify FunctionChain while you're iterating over it.
>
> Any response to my other comment?
>
> > Looking over this patch again, some of the other work involved in updating various data structures isn't complete here; the MachineDominatorTree/MachinePostDominatorTree isn't updated, MachineLoopInfo isn't updated.


My code is in `optimizeBranches()` function, after the `optimizeBranches()` function, the function `MachineBlockPlacement::runOnMachineFunction` will do some clean work and will never use the `MachinePostDominatorTree` info, and this pass don't preserve the `MachinePostDominatorTree` and never use `MachineDominatorTree`, so I need not update the `MachineDominatorTree/MachinePostDominatorTree`.

And I will add the code to update the MachineLoopInfo, becausee it will be used in `alignBlocks()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63972/new/

https://reviews.llvm.org/D63972





More information about the llvm-commits mailing list