[PATCH] D65614: [Reassociate] Stop linearizing all associative expression trees w/o profitability

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D65614#1611255 <https://reviews.llvm.org/D65614#1611255>, @lebedev.ri wrote:

> I'm seeing many regressions in diffs.


Can you point to a specific example of what you mean?  I haven't studied every single one closely, but on a skim, I am not seeing regressions, so I'm curious what you mean?

> Honestly i'd say this is the wrong fix/direction,
>  i don't recall any such thing as register pressure
>  for middle-end IR, there are no registers here, only value.

Right, but for the same reason, why should we be perturbing the input without reason?  We don't have any information about profitability to justify the transform.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65614/new/

https://reviews.llvm.org/D65614