[PATCH] D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map

[Dan Liew via Phabricator via llvm-commits]

delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py:949
   # Add built-in plugins.
+  plugin_proxy.add_plugin(ModuleMapPlugIn())
   plugin_proxy.add_plugin(SysRootFilterPlugIn())
----------------
thakis wrote:
> It looks like we always unconditionally add this plugin, yet this plugin requires otool. Doesn't this break asan_symbolize.py on non-darwin? If not, why not?
Plug-ins can unload themselves by returning `False` from their  `process_cmdline_args(self, pargs)` method. In this particular case if `--module-map` is not provided on the command line then the plug-in will unload itself and will not be used.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60531/new/

https://reviews.llvm.org/D60531