[PATCH] D65601: AMDGPU/GlobalISel: Don't reject shader types

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 12:25:56 PDT 2019


arsenm created this revision.
arsenm added reviewers: nhaehnle, tstellar.
Herald added subscribers: Petar.Avramovic, t-tye, tpr, dstuttard, rovka, yaxunl, wdng, jvesely, kzhuravl.

I'm not sure what complications these present, but the current
argument lowering is pretty much directly copied from the DAG
lowering, so I assume these work as they should.

      

No tests because I'm lazy and things are getting pretty close to the
point where the existing calling-conventions.ll can be shared with
SelectionDAG.


https://reviews.llvm.org/D65601

Files:
  lib/Target/AMDGPU/AMDGPUCallLowering.cpp


Index: lib/Target/AMDGPU/AMDGPUCallLowering.cpp
===================================================================
--- lib/Target/AMDGPU/AMDGPUCallLowering.cpp
+++ lib/Target/AMDGPU/AMDGPUCallLowering.cpp
@@ -555,10 +555,6 @@
   if (CC == CallingConv::AMDGPU_KERNEL)
     return lowerFormalArgumentsKernel(MIRBuilder, F, VRegs);
 
-  // AMDGPU_GS and AMDGP_HS are not supported yet.
-  if (CC == CallingConv::AMDGPU_GS || CC == CallingConv::AMDGPU_HS)
-    return false;
-
   const bool IsShader = AMDGPU::isShader(CC);
   const bool IsEntryFunc = AMDGPU::isEntryFunctionCC(CC);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65601.212881.patch
Type: text/x-patch
Size: 582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190801/448d18f9/attachment.bin>


More information about the llvm-commits mailing list