[llvm] r367443 - [AMDGPU] Fix for vectorizer crash with pointers of different size

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 07:53:43 PDT 2019


Currently not at my workstation, attached is a test case that I scraped
from the logs. This should have a <4 x float> load & store and scalar
arithmetic after going through LoadStoreVectorizer.

On Thu, Aug 1, 2019 at 3:14 PM Arsenault, Matthew <Matthew.Arsenault at amd.com>
wrote:

>
>
>>
> This is too aggressive, it will prevent any pointer pair that's
> addrspacecast'ed from ever being recognized as consecutive. What's the
> reason for not checking the size? I'm seeing regressions where pointers are
> getting loaded from memory and then casted to the right addresspace.
>
> - Ben
>
> Do you have an example where this matters? I would expect any cases that
> are vectorizable and involve an addrspacecast would be taken care of by
> InferAddressSpaces, so the vectorizer doesn’t need to worry about them.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190801/89beb3d1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: addrspacecast.ll
Type: application/octet-stream
Size: 3329 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190801/89beb3d1/attachment.obj>


More information about the llvm-commits mailing list