[PATCH] D65213: [ELF] With --vs-diagnostics, print a separate message for each location of a duplicate symbol.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 23:18:42 PDT 2019


ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: Common/ErrorHandler.cpp:187
+  else if (errorCount == errorLimit) {
+    printErrorMsg(errorLimitExceededMsg);
     if (exitEarly)
----------------
ikudrin wrote:
> ruiu wrote:
> > Why did you have to change this line?
> I did not have to. It is a possible simplification, as we now have a separate method `printErrorMsg`.
Ah, OK, I got confused a little because previously there was a call of `printError(msg)` and `printErrorMsg(...)`, so it looked very similar.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65213/new/

https://reviews.llvm.org/D65213





More information about the llvm-commits mailing list