[PATCH] D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/unittests/Analysis/SearchVectorFunctionSystemTest.cpp:227
+                   ConstantInt::get(Type::getInt32Ty(Ctx), 20)};
+  std::unique_ptr<CallInst> Caller(CallInst::Create(F, Args));
+  CallInst *Call = Caller.get();
----------------
aranisumedh wrote:
> I create the CallInst programmatically here. The stack trace tells me the bug is in `getVectorizedFunction` in SearchVectorFunctionSystem.cpp. When it calls `Call->getModule()`, a segmentation fault occurs. As I understand, the CallInst is probably not getting inserted in the module.
> 
> I was wondering how do I modify the test case so as to suit this functionality?
> 
> 
> 
> 
> 
CallInst should have a constructor/create method that takes a basic block or instruction. Alternatively, call Call->insertXXX later.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64095/new/

https://reviews.llvm.org/D64095