[PATCH] D37166: [builtins] Prevent duplicate definitions for overridden functions

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.
Herald added a subscriber: delcypher.
Herald added a project: LLVM.


================
Comment at: compiler-rt/trunk/lib/builtins/CMakeLists.txt:500
       # architecture specific manner.  This prevents multiple definitions of the
       # same symbols, making the symbol selection non-deterministic.
       foreach (_file ${${arch}_SOURCES})
----------------
Didn't this do the same thing already? What did this down here not catch?

D36555, which went out to review before this change but landed later, added x86_ARCH_SOURCES which contains floatundixf.c which has a specialized implementation. x86_ARCH_SOURCES currently doesn't go through filter_builtin_sources() (due to it not yet being in the tree when this patch landed), but due to this loop down here it appears only once anyways.

So now I'm confused what exactly the effect of this patch here was.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D37166/new/

https://reviews.llvm.org/D37166