[PATCH] D65147: [SimplifyCFG] FoldTwoEntryPHINode(): don't bailout on i1 PHI's if we can hoist a 'not' from incoming values

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 05:20:55 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

This looks like a safe easing of the heuristic, so LGTM.
It would be nice if we could lift "IsFreeToInvert()" from InstCombine to some common location and reuse that here as a follow-up. That function goes further than what is proposed here, and I'm not sure how the extra clauses will interact with SimplifyCFG, so that requires some extra tests to see if it behaving as intended in relation this heuristic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65147/new/

https://reviews.llvm.org/D65147





More information about the llvm-commits mailing list