[PATCH] D65191: [llvm-objdump] Implement highlighting

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/highlight.test:4
+## This test uses ANSI escape sequences and the x86 disassembler.
+# REQUIRES: shell, x86-registered-target
+
----------------
```
# UNSUPPORTED: system-windows
# REQUIRES: shell, x86-registered-target
```


================
Comment at: llvm/test/tools/llvm-objdump/highlight.test:8
+# RUN: llvm-objdump -d %t | FileCheck %s --check-prefix=DISABLED
+# RUN: llvm-objdump -d --color %t | FileCheck %s --check-prefix=ENABLED
+
----------------
`llvm-objdump -d --no-show-raw-insn --color %t | tr -d '\033' | FileCheck %s --check-prefix=ENABLED`


================
Comment at: llvm/test/tools/llvm-objdump/highlight.test:15
+# DISABLED-NEXT: {{619: .* movl    2099697\(%rip\), %edx}}
+# ENABLED-NEXT:  {{619: .* movl    2099697\(.\[0;36m%rip.\[0m\), .\[0;36m%edx.\[0m}}
+
----------------
`# ENABLED-NEXT:  619 movl 2099697([0;36m%rip[0m), [0;36m%edx[0m`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65191/new/

https://reviews.llvm.org/D65191