[PATCH] D65213: [ELF] With --vs-diagnostics, print a separate message for each location of a duplicate symbol.

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

This LGTM, thanks. Lets see what Rui think.



================
Comment at: Common/ErrorHandler.cpp:186
+    printError(msg);
+  else if (errorCount == errorLimit) {
+    printErrorMsg(errorLimitExceededMsg);
----------------
nit: In LLD if one of the code branches is using `{}`, then another should also do that:

```
if (errorLimit == 0 || errorCount < errorLimit) {
  printError(msg);
} else ...
```

(LLVM does not always use this style, but in LLD we always do in this way I think).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65213/new/

https://reviews.llvm.org/D65213