[PATCH] D65213: [ELF] With --vs-diagnostics, print a separate message for each location of a duplicate symbol.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: Common/ErrorHandler.cpp:186
+      printError(match.str(1) + match.str(2));
+      printError(match.str(1) + match.str(3));
+      return;
----------------
grimar wrote:
> ikudrin wrote:
> > grimar wrote:
> > > BTW, this might print only the first error if `errorLimit` is reached.
> > > (I am not sure how much it is critical though).
> > That was made in that way deliberately. It would be weird if, for example, having the error limit of 10 we produce 11 messages, no?
> No more wierd than having a fixed number of errors with `!vsDiagnostics` when error limit == 10/11 and having a different number of errors when `vsDiagnostics` is set.
Well, if you insist, I'll change it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65213/new/

https://reviews.llvm.org/D65213