[PATCH] D65499: [ELF] Fix finding the location in messages for undefined hidden symbols.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/ELF/vs-diagnostics-undefined-hidden.s:2
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: not ld.lld --vs-diagnostics -shared %t.o -o %tout 2>&1 \
----------------
This is generic ELF (OS agnostic) so you can actually use `-triple=x86_64`..


================
Comment at: test/ELF/vs-diagnostics-undefined-hidden.s:3
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: not ld.lld --vs-diagnostics -shared %t.o -o %tout 2>&1 \
+// RUN:   | FileCheck %s
----------------
`%tout` -> `/dev/null`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65499/new/

https://reviews.llvm.org/D65499