[PATCH] D65376: Randomly outline code for cold regions

Tue Jul 30 09:37:42 PDT 2019

hiraditya added a comment.

In D65376#1604460 <https://reviews.llvm.org/D65376#1604460>, @tejohnson wrote:

> In D65376#1603895 <https://reviews.llvm.org/D65376#1603895>, @lebedev.ri wrote:
>
> > I'm not sure it is a good idea to have non-deterministic optimizations.
>
>
> I agree with @lebedev.ri, I don't think non-deterministic optimizations are good as it would make triaging and debugging really difficult. I see @pcc has a follow on suggestion to make this deterministic. At the least that would be needed. But is it useful to do this optimization randomly in practice?

I guess It depends on the workload, for user-facing apps for example, where most of the code is cold. Aggressively outlining reduces program load time.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65376/new/

https://reviews.llvm.org/D65376