[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 08:53:06 PDT 2019


lebedev.ri added a comment.

@dmgreen could you please specify, did you test this point of this patch queue, or this patch itself?
I'm interested in latter, only in perf impact of changing `-phi-node-folding-threshold=2` to `-phi-node-folding-threshold=3`
Otherwise you'd need to test the entire patch queue.

In D65148#1606412 <https://reviews.llvm.org/D65148#1606412>, @craig.topper wrote:

> For the mul overflow case, I wonder if we should be treating extractvalue as free? It won’t generate any code.


`extractvalue` from `@llvm.with.overflow` specifically?
Only for X86, or in general?
That could work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148





More information about the llvm-commits mailing list