[PATCH] D65449: gn build: Use rebase_path on filename args to libcxx/utils/gen_link_script.py

[Hans Wennborg via Phabricator via llvm-commits]

hans created this revision.
hans added reviewers: phosek, thakis.
Herald added a reviewer: EricWF.
Herald added subscribers: llvm-commits, christof.
Herald added a project: LLVM.

Otherwise it fails for me like this:

  $ ninja -j800
  [1/5] ACTION //libcxx/src:cxx_linker_script(//llvm/utils/gn/build/toolchain:stage2_unix)
  FAILED: lib/libc++.so 
  python ../libcxx/utils/gen_link_script.py --input //build.gn/lib/libc++.so.0 --output //build.gn/lib/libc++.so c++abi unwind
  GENERATING SCRIPT: 'INPUT(libc++.so.0 -lc++abi -lunwind)' as file //build.gn/lib/libc++.so
  Traceback (most recent call last):
    File "../libcxx/utils/gen_link_script.py", line 57, in <module>
      sys.exit(main())
    File "../libcxx/utils/gen_link_script.py", line 50, in main
      with open(args.output, 'w') as f:
  IOError: [Errno 2] No such file or directory: '//build.gn/lib/libc++.so'
  ninja: build stopped: subcommand failed.


https://reviews.llvm.org/D65449

Files:
  llvm/utils/gn/secondary/libcxx/src/BUILD.gn


Index: llvm/utils/gn/secondary/libcxx/src/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/libcxx/src/BUILD.gn
+++ llvm/utils/gn/secondary/libcxx/src/BUILD.gn
@@ -236,9 +236,9 @@
       ]
       args = [
         "--input",
-        "$runtimes_dir/libc++.so.0",
+        rebase_path("$runtimes_dir/libc++.so.0", root_build_dir),
         "--output",
-        "$runtimes_dir/libc++.so",
+        rebase_path("$runtimes_dir/libc++.so", root_build_dir),
         "c++abi",
         "unwind",
       ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65449.212333.patch
Type: text/x-patch
Size: 554 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190730/b4eb74a7/attachment.bin>