[PATCH] D65388: [llvm-readelf/llvm-readobj] - Test the case when e_shstrndx==SHN_XINDEX, but sec[0].sh_link is broken.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

It seems to me like the code here and the equivalent code in D65391 <https://reviews.llvm.org/D65391> are basically identical and should be deduplicated, to avoid the need for two different test cases. Could you merge the two, by adding a "CheckType" parameter or similar to the getSectionName code in ELF.h? I was completely independently looking at this myself, after running into an issue with this code relating to some local patches we have, caused by the code duplication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65388/new/

https://reviews.llvm.org/D65388