[PATCH] D62432: [SLPVectorizer] Make the scheduler aware of the TreeEntry operands.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 01:32:22 PDT 2019


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1239
+      assert(isa<Instruction>(Scalars[0]) && "Expected instruction.");
+      auto *I0 = cast<Instruction>(Scalars[0]);
+      Operands.resize(I0->getNumOperands());
----------------
cast includes an isa<>assert - do we really need an extra one?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1247
+          assert(isa<Instruction>(Scalars[Lane]) && "Expected Instruction");
+          auto *I = cast<Instruction>(Scalars[Lane]);
+          assert(I->getNumOperands() == NumOperands &&
----------------
cast includes an isa<>assert - do we really need an extra one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62432/new/

https://reviews.llvm.org/D62432





More information about the llvm-commits mailing list