[PATCH] D65063: [PowerPC] Eliminate loads feeding swaps for vector type by using big-endian load.

[Zixuan Wu (Zeson) via Phabricator via llvm-commits]

wuzish marked 4 inline comments as done.
wuzish added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:13109
+
+    for (; I != E; ++I) {
+      if (*I != i)
----------------
jsji wrote:
> Can this be a range-based for loop?
It's not easy because it's reverse begin and end.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:462
+      /// the vector type to load vector in big-endian element order.
+      LOAD_VEC_BE,
+
----------------
jsji wrote:
> This will overlap with LXVD2X above, it would be great if we can have a follow up NFC to clean up.
Yes, it would be good to merge the implementation of LXVD2X/STXVD2X into LOAD_VEC_BE/STORE_VEC_BE. I would try to do this in another patch. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65063/new/

https://reviews.llvm.org/D65063