[PATCH] D65420: [llvm-lipo] Implement -segalign

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-lipo/segalign.test:5
+
+# RUN: llvm-lipo %t-universal.o %t-arm64.o -create -o %t.o -segalign arm64 100
+# RUN: llvm-objdump %t.o -m --universal-headers | FileCheck --check-prefix=CHECK_SMALL_ARM64 %s
----------------
I'd add a run of llvm-lipo with exactly the same input but without -segalign to make it easier to see the difference.
Also I'd add a comment regarding the format of -segalign (in particular, it expects a hex)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65420/new/

https://reviews.llvm.org/D65420