[PATCH] D65347: [RISCV] Fix uninitialized variable after call to evaluateConstantImm

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 20:44:10 PDT 2019


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

This looks good to me, thanks! Upon review I considered whether evaluateConstantImm should always set VK, but it seems sensible to rely on the caller to initialise it if necessary, as setting VK when evaluateConstantImm failed seems surprising.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65347/new/

https://reviews.llvm.org/D65347





More information about the llvm-commits mailing list