[PATCH] D28855: [CMake] Copy per-component `required_libraries` into `LINK_COMPONENTS`. NFC.

[Bryant Wong via llvm-commits]

IIRC LLVM_LINK_COMPONENTS is already used in a few places. Should they be
normalized to LINK_COMPONENTS as well?

On Fri, Jul 26, 2019, 10:57 AM Chris Bieneman via Phabricator <
reviews at reviews.llvm.org> wrote:

> beanz added inline comments.
> Herald added a subscriber: s.egerton.
>
>
> ================
> Comment at: llvm/lib/Analysis/CMakeLists.txt:1
> +set(LLVM_LINK_COMPONENTS
> +  BinaryFormat
> ----------------
> It would be better to use the `LINK_COMPONENTS` parameter to
> `add_llvm_library` rather than setting this. CMake's variable scoping
> behavior is non-intuitive, which can lead to bugs.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D28855/new/
>
> https://reviews.llvm.org/D28855
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190726/8a6979cc/attachment.html>