[llvm] r367161 - [Remarks] Update unit test to use StringRef::lower

Francis Visoiu Mistrih via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 15:36:20 PDT 2019


Author: thegameg
Date: Fri Jul 26 15:36:20 2019
New Revision: 367161

URL: http://llvm.org/viewvc/llvm-project?rev=367161&view=rev
Log:
[Remarks] Update unit test to use StringRef::lower

Modified:
    llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp

Modified: llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp?rev=367161&r1=367160&r2=367161&view=diff
==============================================================================
--- llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp (original)
+++ llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp Fri Jul 26 15:36:20 2019
@@ -63,14 +63,6 @@ bool parseExpectError(const char (&Buf)[
   return StringRef(Stream.str()).contains(Error);
 }
 
-static std::string toLower(StringRef S) {
-  std::string R;
-  R.reserve(S.size());
-  for (char C : S)
-    R += std::tolower(C);
-  return R;
-}
-
 void parseExpectErrorMeta(StringRef Buf, const char *Error) {
   std::string ErrorStr;
   raw_string_ostream Stream(ErrorStr);
@@ -82,7 +74,7 @@ void parseExpectErrorMeta(StringRef Buf,
 
   // Use a case insensitive comparision due to case differences in error strings
   // for different OSs.
-  EXPECT_EQ(toLower(Stream.str()), toLower(Error));
+  EXPECT_EQ(StringRef(Stream.str()).lower(), StringRef(Error).lower());
 }
 
 TEST(YAMLRemarks, ParsingEmpty) {




More information about the llvm-commits mailing list