[PATCH] D65336: [InstSimplify] remove quadratic time looping (PR42771)

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 13:00:13 PDT 2019


foad added a comment.

Looks OK to me now, thanks.

As a follow-up I might try rewriting the whole thing as a worklist algorithm. At the moment it'll do another pass through the whole function even if there is only one instruction left on the ToSimplify list, which seems pretty wasteful. Although as you say, it might not make any difference to overall compile time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65336/new/

https://reviews.llvm.org/D65336





More information about the llvm-commits mailing list