[PATCH] D65323: If XCode is not installed, `xcodebuild -version -sdk macosx Path` will give xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance In this case...

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 09:22:20 PDT 2019


beanz added inline comments.


================
Comment at: compiler-rt/cmake/base-config-ix.cmake:104
+    if (NOT OSX_SYSROOT)
+      execute_process(COMMAND xcrun -sdk macosx --show-sdk-path
+         OUTPUT_VARIABLE OSX_SYSROOT
----------------
Might as well just call `xcrun` always instead. I think really old versions of `xcrun` don't support this flag, but I doubt that is a problem worth worrying about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65323/new/

https://reviews.llvm.org/D65323





More information about the llvm-commits mailing list