[PATCH] D65334: [llvm] [FileCheck] Use FILECHECK_DUMP_INPUT_ON_FAILURE only when non-empty

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D65334#1602675 <https://reviews.llvm.org/D65334#1602675>, @mgorny wrote:

> We are using it to force verbose output on buildbot ;-).


Good to know.  By the way, you'd get roughly the same output with `FILECHECK_OPTS=-dump-input=fail`, which is not deprecated.  Adding `-v` or `-vv` will provide much more info.

> But setting to an empty value should be very uncommon.

Agreed.

> The uses I've been able to grep in LLVM all set it to `1`.

You mean the FileCheck test suite?  Or are you grepping some user code?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65334/new/

https://reviews.llvm.org/D65334