[PATCH] D65214: [obj2yaml] - Report a error when unable to resolve a sh_link reference properly.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/obj2yaml/elf-shlink.yaml:1
+## Check obj2yaml reports a proper error when unable to resolve
+## a sh_link reference in a regular section.
----------------
jhenderson wrote:
> Should we have a test case to show that it can handle the elf-shlink value otherwise, or does that already exist?
> 
> If it already exists (or for some reason don't want it), perhaps you should rename this file elf-shlink-invalid.yaml.
> Should we have a test case to show that it can handle the elf-shlink value otherwise, or does that already exist?

We have a lot of tests in `tools/obj2yaml` that  do something like: `Link: .dynsym`. I.e. refer to an existent section by name.
But probably this is kind of implicit and not complete way.

So, I think you're right anf it might worth to test the behavior explicitly here. I added the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65214/new/

https://reviews.llvm.org/D65214