[PATCH] D65298: [DivRemPairs] Handling for expanded-form rem - recomposition (PR42673)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 04:20:43 PDT 2019


spatel added a comment.

LGTM - but I'd prefer that someone with a better grasp of C++ / PointerIntPair also have a look to make sure I'm not missing any implementation subtleties.

One question: should we keep track of the dead multiply instructions and remove them in this pass (for example, using RecursivelyDeleteTriviallyDeadInstructions())?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65298/new/

https://reviews.llvm.org/D65298





More information about the llvm-commits mailing list