[PATCH] D65140: [yaml2obj] - Allow custom fields for the SHT_UNDEF sections.

Fri Jul 26 03:47:46 PDT 2019

jhenderson added a comment.

In D65140#1601111 <https://reviews.llvm.org/D65140#1601111>, @grimar wrote:

> In D65140#1600755 <https://reviews.llvm.org/D65140#1600755>, @jhenderson wrote:
>
> > FWIW, rather than messing about with cut and tr, it might have been easier to just use FileCheck directly, i.e. just do `ls -l` | FileCheck %s, and then construct an appropriate regex to skip the irrelevant bits. I don't think it's a big deal either way, but I would probably find it easier to read, personally.
>
>
> I invented the following. But it does not look simpler to me actually...
>
>   # RUN: yaml2obj --docnum=4 %s -o %t4
>   # RUN: ls -l %t3 > %t.txt
>   # RUN: ls -l %t4 >> %t.txt
>   # RUN: FileCheck %s --input-file=%t.txt --check-prefix=SIZE
>  
>   # SIZE: {{^[^ ]*[ ]+[^ ]*[ ][^ ]*[ ][^ ]*[ ]}}[[FILESIZE:[^ ]*]]
>   # SIZE: [[FILESIZE]]
>

I think you might be right, fair enough!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65140/new/

https://reviews.llvm.org/D65140