[PATCH] D65040: [llvm-objcopy] Add support for --add-section for COFF

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 03:47:43 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

In D65040#1601441 <https://reviews.llvm.org/D65040#1601441>, @sdmitriev wrote:

> Sure, I can move --add-section argument string parsing out of ELFObjcopy.cpp and COFFObjcopy.cpp to the CopyConfig.cpp and add necessary test cases. I just suggest to do it as a followup change set instead of doing as part of this patch.


Okay, sounds good. LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65040/new/

https://reviews.llvm.org/D65040





More information about the llvm-commits mailing list