[PATCH] D65215: [obj2yaml] - Teach tool to dump SHT_NULL sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/obj2yaml/elf-null-section.yaml:45
+
+## Check we are able to dump the SHT_NULL section at non-0 index.
+
----------------
Nit: section with a non-zero index


================
Comment at: test/tools/obj2yaml/elf-null-section.yaml:88
+
+## Check we do not dump the SHT_NULL section at the index 0
+## when it does not have any custom fields.
----------------
"with index 0"


================
Comment at: test/tools/obj2yaml/elf-null-section.yaml:116
+
+## Check we dump SHT_NULL sections which are not at the begining
+## of section list even if they don't have any non-null field.
----------------
begining -> beginning


================
Comment at: test/tools/obj2yaml/elf-null-section.yaml:117
+## Check we dump SHT_NULL sections which are not at the begining
+## of section list even if they don't have any non-null field.
+
----------------
of the section list

any non-null fields.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65215/new/

https://reviews.llvm.org/D65215