[PATCH] D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 02:47:35 PDT 2019


grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4486
+  // their corresponding relocation sections.
+  using SectionMap = llvm::MapVector<SectionRef, SectionRef>;
+  SectionMap StackSizeRelocMap;
----------------
grimar wrote:
> Its a bit strange to see `using` here. You use `SectionMap` only once
> and it is not common do do in the missle of function I think.
> I'd just remove.
"do do in the missle of function" -> "to do in the middle of function"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65313/new/

https://reviews.llvm.org/D65313





More information about the llvm-commits mailing list