[PATCH] D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:780
 #if SANITIZER_FREEBSD
+typedef int (*syctlbyname_ptr)(const char *sname, void *oldp, size_t *oldlenp,
+                          const void *newp, size_t newlen);
----------------
Change it to `using` and place it inside the function.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:788
+  if (!real_sysctlbyname)
+    real_sysctlbyname = (syctlbyname_ptr)dlfunc(RTLD_DEFAULT, "sysctlbyname");
+  CHECK(real_sysctlbyname);
----------------
When is `dlfunc(RTLD_DEFAULT, "sysctlbyname")` used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65221/new/

https://reviews.llvm.org/D65221