[PATCH] D65275: [ARM][LowOverheadLoops] Add CPSR defs

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 23:56:36 PDT 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:5226
                  (ins rGPR:$elts, brtarget:$target),
-                 4, IIC_Br, []>,
+                 8, IIC_Br, []>,
                  Sched<[WriteBr]>;
----------------
SjoerdMeijer wrote:
> Instruction sizes: is that something we can, or actually want to test? I don't think I have seen tests for thhat, but was just wondering it because you're changing it here. If there's no precedent for it, perhaps just a comment that we assume that this expands to 2 instructions?
I'll add a comment!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65275/new/

https://reviews.llvm.org/D65275





More information about the llvm-commits mailing list