[PATCH] D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unittests

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 21:11:17 PDT 2019


abrachet marked 5 inline comments as done.
abrachet added inline comments.


================
Comment at: llvm/unittests/ObjectYAML/yaml2ObjectFileTest.cpp:30
+
+  ASSERT_TRUE(!!ErrOrObj);
+
----------------
labath wrote:
> nit: ASSERT_THAT_EXPECTED (from Testing/Support/Error.h) will print the actual error message if this ever fails (instead of just a useless "false is not true").
Thanks! I've been doing this a lot great to know about this better way!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65255/new/

https://reviews.llvm.org/D65255





More information about the llvm-commits mailing list