[PATCH] D65305: [InstCombine] remove flop from lerp patterns

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 16:36:28 PDT 2019


spatel added a comment.

In D65305#1601864 <https://reviews.llvm.org/D65305#1601864>, @lebedev.ri wrote:

> I'm not confident about the FP fast-math flags, but the match/transform looks good.


The required 1 is 'reassoc' - it gives us the ability to rearrange terms however we want. We're also requiring 'nsz' to be safe on related factorizations, so I kept that here to be conservative. In practice, if we're allowed to  'reassoc', then we've been given license to go crazy with FP, so all of the other flags are likely in play too (aka 'fast').


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65305/new/

https://reviews.llvm.org/D65305





More information about the llvm-commits mailing list