[PATCH] D64802: [llvm-ar][test] Add tests failing on Darwin

James Nagurne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 09:08:09 PDT 2019


JamesNagurne added a comment.

@gbreynoo

Our team maintains a downstream embedded ARM cross compiler, and these tests are failing on our Mac validations.
The key problem here I believe is the 'XFAIL: darwin' doesn't seem to work how you expect it to, and I'm not aware of a good alternative that I can suggest. Hopefully you or someone else has one.

XFAIL: darwin triggers if either the 'available_features' has darwin in it, or if the **target** triple contains 'darwin'.
Available features is not populated with the current host platform, and the target triple in our case is for our embedded ARM. Thus, the XFAIL is not active, and the failures are treated as such.

Do you know of any good solution for this? In summary:

1. Our tools (both clang and llvm-ar) are built on and run on Mac
2. The compiler (just clang) generates embedded ARM code
3. This test fails for llvm-ar built on and run on on mac
4. These lit tests seem to assume 2 implies 3, when in actuality, 1 implies 3


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64802/new/

https://reviews.llvm.org/D64802





More information about the llvm-commits mailing list