[PATCH] D65215: [obj2yaml] - Teach tool to dump SHT_NULL sections.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 01:46:29 PDT 2019


MaskRay added inline comments.


================
Comment at: tools/obj2yaml/elf2yaml.cpp:245
+      // normally creates the zero section at index 0 implicitly.
+      if (&Sec - &Sections[0] == 0) {
+        const uint8_t *Begin = reinterpret_cast<const uint8_t *>(&Sec);
----------------
```
      if (&Sec == &Sections[0] && memchr(&Sec, 0, sizeof Sec) == nullptr)
        break;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65215/new/

https://reviews.llvm.org/D65215





More information about the llvm-commits mailing list