[PATCH] D65131: [PowerPC][NFC] Added `getDefMIPostRA` method so that other methods don't need to implement it repeatedly

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 23:55:36 PDT 2019


shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.

LGTM.
Please fix the minor comments when commit this.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:143
 
+  // In PostRA phase, try to find instruction defines Reg before MI.
+  // SeenIntermediate is set true if uses between DefMI and MI exist.
----------------
MI -> \p MI
Reg -> \p Reg


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:144
+  // In PostRA phase, try to find instruction defines Reg before MI.
+  // SeenIntermediate is set true if uses between DefMI and MI exist.
+  MachineInstr *getDefMIPostRA(unsigned Reg, MachineInstr &MI,
----------------
SeenIntermediate -> \p SeenIntermediateUse
is set -> is set to?
MI -> \p MI


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65131/new/

https://reviews.llvm.org/D65131





More information about the llvm-commits mailing list