[PATCH] D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unittests

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

Thanks for taking this on. I look forward to being able to use this in lldb tests.

I'm not an owner here, but the main question I have is about the library-readiness of the code you're moving. I see it's doing things like spewing errors to stderr and even calling exit(), neither of which is a very nice thing to do for a library (even if it's just a "test" library). Do you have any plans for addressing that?



================
Comment at: llvm/unittests/ObjectYAML/yaml2ObjectFileTest.cpp:30
+
+  ASSERT_TRUE(!!ErrOrObj);
+
----------------
nit: ASSERT_THAT_EXPECTED (from Testing/Support/Error.h) will print the actual error message if this ever fails (instead of just a useless "false is not true").


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65255/new/

https://reviews.llvm.org/D65255