[PATCH] D64759: [CodeGen] Don't resolve the stack protector frame accesses until PEI

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 14:30:35 PDT 2019


thegameg added a comment.

In D64759#1599892 <https://reviews.llvm.org/D64759#1599892>, @efriedma wrote:

> If there isn't any free register, the scavenger will spill a register to the emergency spill slot.  That doesn't have to be any particular register; it can be basically any allocatable register.  So if one or two registers are particularly sensitive, we could specifically forbid the scavenger from spilling them.


I agree, we could do that. It would require parts of the code to keep track of the register used for the guard and avoid it at all cost. Do you think this is blocking for this fix to get in?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64759/new/

https://reviews.llvm.org/D64759





More information about the llvm-commits mailing list