[PATCH] D65235: CrashHandler: be careful about crashing while handling

[Jordan Rose via Phabricator via llvm-commits]

jordan_rose added a comment.

Sure, I guess. I suspect most crashes-while-crashing are from the PrettyStackTrace machinery, not these allocations, but you're right that we can get a partial string out of it if it's short enough.



================
Comment at: llvm/lib/Support/PrettyStackTrace.cpp:137
+using CrashHandlerString = SmallString<2048>;
+using CrashHandlerStringStorage = std::aligned_storage<sizeof(CrashHandlerString)>::type;
+static CrashHandlerStringStorage crashHandlerStringStorage;
----------------
Nitpick: `llvm::AlignedCharArrayUnion<CrashHandlerString>` would also include the alignment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65235/new/

https://reviews.llvm.org/D65235