[PATCH] D64621: [ARM] Make sure that the constant pool does not keep in the middle of an IT block.

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

OK thanks. LGTM. Lets give this a go and see how it does.



================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1360
+          std::max(BaseInsertOffset, Offset + TII->getInstSizeInBytes(*I) + 1);
+      assert(I != UserMBB->end() && "Fell off end of block");
+    }
----------------
Better to move this up a line, so we hit the assert before trying to dereference I. Hopefully (I believe) it won't come up.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64621/new/

https://reviews.llvm.org/D64621