[PATCH] D65141: [DivergenceAnalysis] Add methods for querying divergence at use

[Jay Foad via Phabricator via llvm-commits]

foad marked 3 inline comments as done.
foad added a comment.

> It's missing tests though -- I'm not sure if we want to print this additional information in the divergence printer

Me neither. I'm open to suggestions.



================
Comment at: llvm/lib/Analysis/LegacyDivergenceAnalysis.cpp:365
+  }
+  return DivergentValues.count(U->getUser()) || DivergentUses.count(U);
+}
----------------
nhaehnle wrote:
> What's the rationale for checking the user here as well?
> 
> For example, if the user is a binary operation that is divergent only because the **other** use is divergent, then I'd expect this function to return false...
This was a subtle typo, getUser() instead of get(). Thanks for catching it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65141/new/

https://reviews.llvm.org/D65141