[PATCH] D65070: [LLVM-C][OCaml] Add a fast linker binding

Timotej Kapus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 01:38:16 PDT 2019


kren1 marked an inline comment as done.
kren1 added inline comments.


================
Comment at: lib/Linker/LinkModules.cpp:617
+  std::unique_ptr<Module> M(unwrap(Src));
+  return L->linkInModule(std::move(M), Linker::Flags::None, {});
+}
----------------
CodaFi wrote:
> Can you expose these two defaulted arguments in the bindings as well?  
Exposing them is not trivial, because I would have to introduce new types for Flag and a trampoline for the callback. I removed them to be implicit and in line with `LLVMLinkModules2`. If you really want me to add them, I would prefer to do it as a separate diff.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65070/new/

https://reviews.llvm.org/D65070





More information about the llvm-commits mailing list