[PATCH] D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries

[Seiya Nuta via Phabricator via llvm-commits]

seiya added a comment.

In D63395#1598087 <https://reviews.llvm.org/D63395#1598087>, @alexshap wrote:

> the code looks good to me, but we need tests. I'd add simple tests which take YAML (similarly to how the existing tests work), generate MachO (using yaml2obj), copy it using llvm-objcopy, 
>  dump the results (using llvm-readobj and obj2yamal) and verify that the output is what we expect. Plus those tools will parse the binary generated by llvm-objcopy thus they will verify (to some extent) that we have built a valid  MachO object file.


I'd like to add tests in the next (and the last piece for executable support) patch which implements layout algorithm for executables/shared libraries. This patch focuses on copying some load commands (LC_DYSYMTAB, etc.) that are used in them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63395/new/

https://reviews.llvm.org/D63395