[PATCH] D64984: [Verifier] Verify all blockaddress constants left over have at least one user.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 17:24:49 PDT 2019


efriedma added a comment.

I'm not sure this is something we can reasonably enforce without making big changes in other areas of the compiler.  For example, we call eraseFromParent() all over the place, and some large fraction of those calls could eliminate the last use of a blockaddress.

Places that need this soft of cleanup for global variables usually call Constant::removeDeadConstantUsers().  Not sure if we try to do anything like that for blockaddress constants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64984/new/

https://reviews.llvm.org/D64984





More information about the llvm-commits mailing list