[PATCH] D65172: [SafeStack] Insert the deref before remaining elements

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 16:45:19 PDT 2019


vsk added a comment.

Mind extending debug-loc2.ll with, say, a '!DIExpression(DW_OP_deref, DW_OP_LLVM_fragment, 0, 32)' example?



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1606
+    Ops.append(DIExpr->elements_begin(), DIExpr->elements_end());
     DIExpr = Builder.createExpression(Ops);
   }
----------------
Can this whole block be replaced with: 'DIExpr = DIExpression::prepend(DIExpr, 0, Offset)'? It should handle fragments correctly and avoid inserting any extra derefs.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65172/new/

https://reviews.llvm.org/D65172





More information about the llvm-commits mailing list